Adding largescale ASR model for speechbrain #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nithinraok
requested changes
Feb 6, 2025
nithinraok
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
since you are using same model but different settings, I don;t think this would play well when HF outputs results as the files are saved based on model_name and eval data. Pls run on your machine to verify this. Otherwise rest all LGTM
There was a problem hiding this comment.
To be honest, i've played a bit with a local a100, and the decoding seems to slow compared to what I would have expected (what we see within SB). I'll investigate a bit.
There was a problem hiding this comment.
Yes please don't run any test - there is something fishy. I'll investigate.
Vaibhavs10
approved these changes
Feb 6, 2025
|
all fixed @Vaibhavs10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
This is adding the scripts and modifications to run the evaluation of https://huggingface.co/speechbrain/asr-conformer-largescaleasr . I don't have an A100 available right now ... AND some of the datasets should not be used on company clusters due to license. Any chance that you could run the evaluation?
Thanks!